Errors in mds.py

Question

Errors in mds.py

pedestrian0423 opened this issue 6 years ago · comments

I having a problem in running pylocus for my localization program.
It seems to be f is not defined and used in the function 'x_from_eigendecomp' in mds.py

However, with the revision 9a322e4, my code works fine.

Here is an error message.
File "d:\code\pylocus\pylocus\algorithms.py", line 9, in execute_method noisy_edm, real_points=real_points, method='geometric') File "d:\code\pylocus\pylocus\algorithms.py", line 176, in reconstruct_mds Xhat = MDS(edm, d, method, False).T File "d:\code\pylocus\pylocus\mds.py", line 48, in MDS return x_from_eigendecomp(factor, u, dim) File "d:\code\pylocus\pylocus\mds.py", line 19, in x_from_eigendecomp return ((f * u).T)[:dim, :] NameError: name 'f' is not defined

Frederike Dümbgen · Answer 1 · Sat May 12 2018 08:08:42 GMT+0800 (China Standard Time)

Thank you for pointing this out. Are you using the pip version or the latest github version?

Seungho Yoo · Answer 2 · Sat May 12 2018 08:17:48 GMT+0800 (China Standard Time)

Thanks for the reply.
I tried to use latest github version of pylocus, with python 3.6.5.

Frederike Dümbgen · Answer 3 · Fri Jul 13 2018 20:38:37 GMT+0800 (China Standard Time)

@pedestrian0423, this was a typo introduced by a different pull request it seems. I am setting up continuous integration right now such that things like this do not happen in the future. Thank you for your help!