several issues installing this software

[Google Code Exporter]

Running on Ubuntu 13.04

* GCC fails because the Makefile is missing the linking with the Math library: 
one should add -lm to the LIBS definition:
LIBS=$(SDL_LIBS) -lSDL_mixer -lSDL_ttf -lm

* the README should specify that one should copy both FreeMono.ttf and lba.cfg 
from the bin/ (in trunk) to the LBA directory.

* running the program fails because midi_mi_win.hqr is not found.
From src/resources.c:
int8 * HQR_MIDI_MI_WIN_FILE             = "midi_mi_win.hqr";
int8 * HQR_MIDI_MI_WIN_MP3_FILE = "midi_mi_win_mp3.hqr";
int8 * HQR_MIDI_MI_WIN_OGG_FILE = "midi_mi_win_ogg.hqr";

However in the original LBA CD (I bought mine in France in summer 1995), none 
of these 3 files are present. There is only midi_mi.hqr

Thanks.

Original issue reported on code.google.com by [e-mail] on 29 Apr 2013 at 4:36

[Google Code Exporter]

OK so extracting the content of LBAWIN with wine, I got the file 
midi_mi_win.hqr.

Is this file better than the original (midi_mi.hqr)?

Then it fails on opening the vox file, because it is looking for EN_gam.vox and 
the file copied from the CD is lower case: en_gam.vox. (unix is case-sensitive)

I changed the language code in the source to lower case to match the CD 
filename (I think CD filesystem is also case sensitive) and recompiled. Now it 
is working.

Original comment by [e-mail] on 30 Apr 2013 at 11:18

[Google Code Exporter]

 * Math library is a recent change so thanks for let us know.

 * Readme file will be update soon. FreeMono is only needed in a DEBUG version of the engine when GAMEMOD macro is active. CFG file should indeed be copied but the default game values have to work without it. Its something I need to check as well.

 * Midi_mi HQR is a know issue. The file has an old format that isn't played by the SDL mixer. Since we don't have yet an engine converter of this midi format, we are currently using the Midi_mi_win.HQR which is compatible and came with LbaWin engine. The engine should make this convertion itself without the need of having to release copyright material.
The other mp3 and ogg files are only test files for modding and they will be 
probably be cutoff in the next commits.

 * There are known issues with the file cases. Recently Felipe has made some changes but probably not working on all situations. I will probably install a Ubuntu port to address those issues better;


Thanks for your input and I will update the TODO to list those changes. If you 
find anything useful, let us know ;)
Also, feel free if you want to help us.

Original comment by [e-mail] on 30 Apr 2013 at 12:37

[Google Code Exporter]

[deleted comment]

[Google Code Exporter]

[deleted comment]

[Google Code Exporter]

Regarding the midi_mi.hqr issue, I have a patch that seems to be working. It 
basically converts eXtended MIDI (which the original DOS music uses) to regular 
MIDI. Please test it and let me know if it works for you. You have to set Sound 
to 4 in lba.cfg to use it.

Original comment by [e-mail] on 22 Dec 2013 at 11:16

Attachments:

• xmidi_support.patch

[Google Code Exporter]

And here's a patch for the case insensitive fopen(). I just added 
https://github.com/OneSadCookie/fcaseopen (2 files with ifdef's for WIN32) and 
used that instead of the regular fopen(). I have yet to test my patches on 
Windows or OSX.

Original comment by [e-mail] on 23 Dec 2013 at 1:06

Attachments:

• fcaseopen.patch

[Google Code Exporter]

Also added the fopen patch. Just made some fixes for WIN32.

Original comment by [e-mail] on 26 Dec 2013 at 7:54

[Google Code Exporter]

I believe the Music must have been remastered with the WIN version, since that 
version uses 2 MIDI channels instead of just 1 (at least for the first song). 
What we could do is check for the existence of the WIN version upon 
initialization and set some kind of  cfgfile variable (cfgfile.cd_release, 
0=auto, 1=DOS, 2=WIN). If more differences are discovered later, we can again 
use that variable.

Original comment by [e-mail] on 27 Dec 2013 at 2:28

[Google Code Exporter]

Sort of like in this patch! Please review and get back with comments.

Also, IMHO it's best to only declare cfgfile in main.h and then define it in 
main.c (patch atteched). Opinions?

Original comment by [e-mail] on 27 Dec 2013 at 4:21

Attachments:

• autodetect_win_dos_music.patch
• extern_cfgfile.patch

[Google Code Exporter]

Ok, it seems my music patch really screws up the tempo/speed of all other 
sounds. Will have to dig deeper into this some other time. It's Christmas and I 
got lots of other stuff to do

Original comment by [e-mail] on 23 Dec 2013 at 1:14

[Google Code Exporter]

Thanks risca for your help.
I include the music patch in the code and it seams to be working well. I didn't 
notice any tempo issue.
I've change the Sound type from 4 to 1 since this is the orignal one we should 
be using first.

I don't know yet if I will keep with the conversion the time we play the midi, 
or if I should create a HQR file out of it. Anyway, its working like a charm ;)

Original comment by [e-mail] on 26 Dec 2013 at 7:22

[Google Code Exporter]

[deleted comment]

[Google Code Exporter]

Original comment by [e-mail] on 29 Mar 2014 at 2:19

• Changed state: Done

[Google Code Exporter]

Oh, and I also found out that fcaseopen() doesn't seem to handle paths that 
contain '//' very well. Is there a reason that "fla//", "save//", and "vox//" 
are used instead of simply "fla/", "save/", and "vox/"? Perhaps a new issue is 
in order?

In addition, my version of LBAWIN only have the "midi_mi_win.hqr" and NOT the 
"midi_mi.hqr". Seems like there is no other choice than to handle both 
gracefully.

Original comment by [e-mail] on 27 Dec 2013 at 4:30

[Google Code Exporter]

I applied both paths, thanks.
The idea to auto detect the midi file is pretty nice and works really well. 

LbaWin don't have any midi file together with the bundle, it generates the file 
using midi_mi in the first time it runs.

Don't remember why the paths were with double slash, probably something old 
related with Windows version, but I tried without them and its working well. 

Btw, I add you as a committer, so feel free to directly commit in the project 
instead of creating the paths ;)

I will try to create a public version with those fixes before 4 January, 
because the public release still has the old prequengine name and will be 
better to make a proper one.

Original comment by [e-mail] on 27 Dec 2013 at 12:27

• Changed state: Accepted

[Google Code Exporter]

Thanks!

Should this issue be closed, perhaps?

Original comment by [e-mail] on 27 Dec 2013 at 4:33