Giters

Kwentsir / Food-Recipe-App

Your entire recipe collection, inventories, and ingredients are all tracked by the Food Recipe App. You can create recipes, record ingredients, keep track of what you have, build shopping lists based on what you have and what a recipe calls for, and save ingredients.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[1pt] Set up kanban board

Kwentsir opened this issue · comments

commented

This is a link to the kanban board setup of our Food-Recipe project.
https://github.com/users/Kwentsir/projects/4/views/1
We are two people working on this project.
@Kamzzy
@Kwentsir

commented

Hi @Kwentsir and @Kamzzy ,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

✔️ Good design

Required Changes ♻️

Kindly ensure all your cards have a task description:
image

  • Kindy ensure all tasks in the project have been assigned, and are distributed fairly among members.
  • Kindly add a task to check that no N + 1 queries are happening.
    image

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

commented

Hi Team👋,

Highlights💡

  • Added N + 1 problem card as suggested by the previous reviewer.✔️
  • Assigned all cards.✔️

STATUS: APPROVED 🕺🥳

Congratulations🍾🥳!! Your project is ready for presentation! There is nothing else to say other than... it's time to merge it :shipit:

Good luck! 🎉

Optional Suggestions:

  • N/A

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brytebee in your question so I can receive the notification.

Use @brytebee on slack for faster responses.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.