Refactor of player movement

[Jan Iwaszkiewicz]

icy-tower-ai/main.py

Lines 54 to 69 in 8ef6fc8

 for event in pygame.event.get():  # User did something 
     if event.type == pygame.QUIT:  # If user clicked close 
         carryOn = False  # Flag that we are done so we can exit the while loop 
     keys = pygame.key.get_pressed() 
     if keys[pygame.K_LEFT]: 
         playerMoveVector[0]=-playerSpeed 
     if keys[pygame.K_RIGHT]: 
         playerMoveVector[0]=playerSpeed 
     if keys[pygame.K_UP]: 
         playerMoveVector[1]=-playerSpeed 
     if keys[pygame.K_DOWN]: 
         playerMoveVector[1]=playerSpeed 
     if keys[pygame.K_RIGHT]==False and keys[pygame.K_LEFT]==False: 
         playerMoveVector[0] = 0 
     if keys[pygame.K_DOWN]==False and keys[pygame.K_UP]==False: 
         playerMoveVector[1] = 0 

It can be done via creation of a class that will handle movements of a player:

ACTIONS = {
    pygame.K_LEFT:  {"axis": 0, "value": -playerSpeed},
    pygame.K_RIGHT: {"axis": 0, "value": playerSpeed},
    pygame.K_UP:    {"axis": 1, "value": -playerSpeed},
    pygame.K_DOWN:  {"axis": 1, "value": playerSpeed},
}


class PlayerMoveVector():

    def __init__(self):
        self.vector = [0, 0]

    def __getitem__(self, i):
        return self.vector[i]

    def do_action(self, key):
        self.vector[ACTIONS[key]["axis"]] = ACTIONS[key]["value"]

    def clear(self):
        self.vector = [0, 0]


player_move_vector = PlayerMoveVector()


while carryOn:
    # --- Main event loop

    for event in pygame.event.get():   # User did something
        if event.type == pygame.QUIT:  # If user clicked close
            carryOn = False            # Flag that we are done so we can exit the while loop
        elif event.type == pygame.KEYDOWN:
            player_move_vector.do_action(event.key)
        elif event.type == pygame.KEYUP:
            player_move_vector.clear() # This will populate whole vector with 0's

We can discuss benefits and details of this approach on the next meeting.