KusStar / react-native-fast-url

A Fast URL and URLSearchParams Polyfills for React Native.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Implementing setters + adding tests

zacharyfmarion opened this issue Β· comments

Hey! Great project...fun fact I was halfway through implementing the exact same thing (using the same c++ library) when I realized it had already been done...great minds πŸ˜„. Just wanted to quickly check whether you would be okay with me putting up a PR to add support for all the setter methods and adding some unit tests that run in the example app (similar to here). I'm a bit hesitant to integrate this library at my company without any testing.

Yes! I was too busy to add it before.
It would great if you make a PR for tests.
Please feel free to make it.