Giters

KundaPanda / strawberry-django-jwt

[UNMAINTAINED] JSON Web Token (JWT) authentication for Django with Strawberry GraphQL

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Relax strawberry-graphql dependency requirement

edouardruiz opened this issue · comments

commented

Hi,

Thanks for updating strawberry-django-jwt to make it compatible with strawberry-graphql>=0.69.0. However the latest version (0.1.2) requires strawberry-graphql>=0.73.8,<0.74.0.

Would it be possible to relax this requirement to allow strawberry-graphql>=0.74.0 and further releases? strawberry-graphql seems to evolve quite fast...

commented

Hi,

Thank you for the issue. It seems like the way tests are run causes changes in pyproject.toml (i.e. when testing against latest strawberry-graphql, the requested version updates to the latest one in the toml file).

Since the way the package-version-specific tests are executed is definitely sub-optimal, I'll try to update it as well so that this issue stops occurring when I forget to double-check committed files after running tests.

commented

Hi @KundaPanda, I face a similar issue today when I try to install strawberry latest release (0.81.0). strawberry-django-jwt requires strawberry-graphql = ">=0.69.0,<0.81.0". Wouldn't it be easier to simply remove the upper bound or set it to a major version (like 1.0)?

commented

Hi, this is definitely an option but I have decided to keep the highest supported versions for strawberry-graphql limited because in the past there have been some non-major breaking releases. Combined with a high-frequency release schedule, I thought it would be better to keep it that way, update dependencies using dependabot and release more often as well.

I will, however, try to keep the versions more relaxed again. If some incompatibility issues arise, users may need to limit the strawberry-graphql versions manually before I have enough time to fix it.