Krisiacik / ImageViewer

An image viewer à la Twitter

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Crash in iPad .

prasannachitnis opened this issue · comments

When we tap(Long press) on image viewer in full screen mode app crashes.Following is the log of crash. iPad Air OS version: 11.2

2018-03-02 14:37:07.114809+0530 [72442:39488480] Attempt to present <UIActivityViewController: 0x7fe3602bfc00> on <.ImageGalleryViewController: 0x7fe35f87f600> which is waiting for a delayed presention of <UIActivityViewController: 0x7fe35d09f800> to complete
2018-03-02 14:37:07.204375+0530 ***********************[72442:39488480] *** Terminating app due to uncaught exception 'NSGenericException', reason: 'Your application has presented a UIActivityViewController (<UIActivityViewController: 0x7fe35d09f800>). In its current trait environment, the modalPresentationStyle of a UIActivityViewController with this style is UIModalPresentationPopover. You must provide location information for this popover through the view controller's popoverPresentationController. You must provide either a sourceView and sourceRect or a barButtonItem. If this information is not known when you present the view controller, you may provide it in the UIPopoverPresentationControllerDelegate method -prepareForPopoverPresentation.'
*** First throw call stack:
(
0 CoreFoundation 0x000000010cfcd12b __exceptionPreprocess + 171
1 libobjc.A.dylib 0x000000010bdb7f41 objc_exception_throw + 48
2 UIKit 0x000000010efabb25 -[UIPopoverPresentationController presentationTransitionWillBegin] + 3290
3 UIKit 0x000000010e42f939 __71-[UIPresentationController _initViewHierarchyForPresentationSuperview:]_block_invoke + 2458
4 UIKit 0x000000010e42d0b9 __56-[UIPresentationController runTransitionForCurrentState]_block_invoke + 436
5 UIKit 0x000000010e2bfd59 _runAfterCACommitDeferredBlocks + 318
6 UIKit 0x000000010e2aebb1 _cleanUpAfterCAFlushAndRunDeferredBlocks + 280
7 UIKit 0x000000010e2de0e0 _afterCACommitHandler + 137
8 CoreFoundation 0x000000010cf6fc07 CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION + 23
9 CoreFoundation 0x000000010cf6fb5e __CFRunLoopDoObservers + 430
10 CoreFoundation 0x000000010cf54124 __CFRunLoopRun + 1572
11 CoreFoundation 0x000000010cf53889 CFRunLoopRunSpecific + 409
12 GraphicsServices 0x00000001135459c6 GSEventRunModal + 62
13 UIKit 0x000000010e2b45d6 UIApplicationMain + 159
14 *********************** 0x00000001042df617 main + 55
15 libdyld.dylib 0x00000001118a5d81 start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

For Ipad it's failing because of long press on image

This PR solves the problem #201.
Let's wait any response.

commented

pod 'ImageViewer', :git => 'https://github.com/Rdxer/ImageViewer.git'

Use this

@Krisiacik what's the fix for this? could you please accept the PR mentioned above?