KonradHoeffner / rickview

quick RDF viewer

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

XML and JSONLD export options are still displayed even if the feature is used

KonradHoeffner opened this issue · comments

There are many factors at play here:

  • Conditional compilation and features make testing harder (powerset of features problem) but they allow reduction in binary size.
  • We already have everything activated as default features by default, and most users probably don't compile RickView by themselves and even if they do they probably don't disable default features, so this is unlikely to be an actual problem for the users.
  • The conditional compilation in RickView is quite straight forward and well separated and could be helpful in the future, for example if there is ever a bug in the XML dependency.
  • The binary size doesn't differ that much between all features (around 14.2 MB) and no features (~ 12.7 MB). For this measurements, strip = true was deactivated for the cargo bloat tool, so in reality the difference would be even less.
  • The export options are displayed in data/resource.html, which is statically included in main.rs`. Changing this wouldn't be worth it.

Conclusion

  • Keep conditional compilation and manually compile it with no features, but officially support only the default feature set for now.
  • Notify users if the output value is not recognized.