Koniverse / SubWallet-Extension

SubWallet is the comprehensive non-custodial wallet solution for Polkadot, Substrate & Ethereum ecosystems.

Home Page:https://www.subwallet.app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Extension - Add validate account in case sign transaction with Ledger account

ThaoNguyen998 opened this issue · comments

Describe the task
Add validate account in case sign transaction with Ledger account

Expect: Show message on confirmation: "Wrong device. Connect your previously used Ledger and try again"

Version test : http://14.224.129.242:8900/s/DgK8ZwADWBss7BS

  • Can't sign with ledger account

Version test : http://14.224.129.242:8900/s/DseLF3PQNcSiw4z

  • Re-check error of not displaying message when first clicking Approve button

Image

  • Don't show message when click approve
    1122

Version test : http://14.224.129.242:8900/s/p6n3GRZ8crWSaJR

  • When changing back to ledger but choosing another network, the message is not displayed

Image

Image

Expect :

Image

Re-check with cases :

  • Check when sign message :
  • Attach account with ledger A but sign with ledger B
  • Check when changing back to ledger ( choose same network )
  • Check when changing back to ledger but choosing another network
  • Check when not connected to ledger
  • Re-check with normal account
  • Check when sign Transfer with dApp :
  • Attach account with ledger A but sign with ledger B
  • Check when changing back to ledger ( choose same network )
  • Check when changing back to ledger but choosing another network
  • Check when not connected to ledger
  • Re-check with normal account
  • Check when Transfer in wallet :
  • Attach account with ledger A but sign with ledger B
  • Check when changing back to ledger ( choose same network )
  • Check when changing back to ledger but choosing another network
  • Check when not connected to ledger
  • Re-check with normal account

Version test :

Validation passed in case :

  • Install/Update version
  • Re-check on Firefox

Image

  • Check when sign message
  • Check when sign Transfer with dApp
  • Check when Transfer in wallet

Attach account with ledger A but sign with ledger B

Image

Image

Image

Check when changing back to ledger ( choose same network )

Image

Check when changing back to ledger but choosing another network

Image

The error occurs when there is a communication issue between the device and the ledger.

Image

Image

Check when not connected to ledger => Related to issue #2568 (comment)

Screenshot (811)
The error occurs when there is a communication issue between the device and the ledger.

Image
The error occurs when the ledger cannot be detected for connection.

image
The error occurs when the ledger disconnects or actively terminates the connection to the device.

Re-check with normal account