Kometa-Team / Community-Configs

Config files for Kometa

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug]: space_chef%20/

planetrocky opened this issue · comments

Link to File

https://github.com/meisnate12/Plex-Meta-Manager-Configs/tree/master/space_chef%20

Version Number

ca8af78

What branch are you on?

master

Describe the Bug

Is it deliberate to have a the folder name "space_chef " with a trailing 0x20 (space character)? This creates problems checking out on Windows:

Windows Shell won't allow trailing spaces, see here:

https://learn.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/file-folder-name-whitespace-characters

$ git checkout
error: invalid path 'space_chef /Example Posters with Overlays/Breaking Bad.png'
error: invalid path 'space_chef /Example Posters with Overlays/Cosmos.png'
error: invalid path 'space_chef /Example Posters with Overlays/IMAX - Hidden Universe.png'
error: invalid path 'space_chef /Example Posters with Overlays/Oppenheimer.png'
error: invalid path 'space_chef /Example Posters with Overlays/The Matrix.png'
error: invalid path 'space_chef /Example Posters with Overlays/The Office.png'
error: invalid path 'space_chef /Example Posters with Overlays/The Return of the King [Extended].png'
error: invalid path 'space_chef /Example Posters with Overlays/The Shawshank Redemption.png'
error: invalid path 'space_chef /Example Posters with Overlays/Westworld.png'
error: invalid path 'space_chef /README.md'

Tagging @nichols89ben since it was their changes that got merged that caused this.

Tagging @nichols89ben since it was their changes that got merged that caused this.

Edited!

thanks, merged!

@cpt-kuesel @nichols89ben

Looks like this didn't correct the issue, the problem was an extra space in the path, not the underscore (which was what the commit changed) windows REALLY doesn't like the extra space, linux doesn't care

Resolving deltas: 100% (5047/5047), done.
error: invalid path 'space-chef /Example Posters with Overlays/Breaking Bad.png'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed

@msorelle came here and was about to say the same :) It's the dangling 0x20 (space character) that Windows shell doesn't like:

https://learn.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/file-folder-name-whitespace-characters

This issue needs opening again please.

@nichols89ben I've updated my original post to clarify the issue a little :)

As a useless fact, you can actually create files in Windows with those spaces; it's just then really hard to delete them, or use them :)