Declaration of Barryvdh\Snappy\IlluminateSnappyPdf::getFileContents($filename) must be compatible with Knp\Snappy\AbstractGenerator::getFileContents(string $filename): string

[William Desportes]

   Symfony\Component\Debug\Exception\FatalErrorException  : Declaration of Barryvdh\Snappy\IlluminateSnappyPdf::getFileContents($filename) must be compatible with Knp\Snappy\AbstractGenerator::getFileContents(string $filename): string

  at /var/www/vendor/barryvdh/laravel-snappy/src/IlluminateSnappyPdf.php:27
    23|      * @param string $filename
    24|      *
    25|      * @return string
    26|      */
  > 27|     protected function getFileContents($filename)
    28|     {
    29|         return $this->fs->get($filename);
    30|     }
    31| 

[William Desportes]

    "require": {
        "barryvdh/laravel-snappy": "^0.4.4"
   }
    "conflict": {
        "knplabs/knp-snappy": "1.3.0"
    },

[William Desportes]

Please mark this package as conflicts with the other two one or fix this bug :)

[Alessandro Pozzi]

Hello,
Sorry for the inconvenience, it skipped my checks. I'm gonna fix it and release a new tag.

[Alessandro Pozzi]

I think I'll be able to fix it this afternoon, I'll release a new tag right away then 😉

[Alessandro Pozzi]

@williamdes I just released a new tag, let me know if the issue still occurs 😉

[William Desportes]

@williamdes I just released a new tag, let me know if the issue still occurs wink

Seems to be fixed, composer update ran correctly

[Alessandro Pozzi]

Cool, sorry again!

[William Desportes]

Cool, sorry again!

No worries, the CI did catch it and nothing got deployed ;)
Thanks for the very quick fix !

[Barry vd. Heuvel]

So I don't have to change anything on my end?

[Alessandro Pozzi]

Nope 😉