KnpLabs / KnpRadBundle

Rapid Application Development for Symfony2 [UNMAINTAINED]

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

We need a new stable release

akovalyov opened this issue · comments

@docteurklein the latest release is 2.3.2(actually, GitHub shows v2.3.1 as latest) which is incompatible with stable symfony 2.5.0
Knp\RadBundle\Controller\Controller::createAccessDeniedException->createAccessDeniedException() has another access level than symfony/symfony@183d0ec

ho, thanks for pointing this out!

I'll try to do that ASAP, but I haven't much time right now.

I just removed this method, since it as already defined in the base class.

Can you tell me if it fixes the probkem for you ?
If so, I'll tag a new release.

@docteurklein I would be happy to say that it fixes the problem

diff --git a/composer.json b/composer.json
-        "knplabs/rad-bundle": "~2.3@dev",
+        "knplabs/rad-bundle": "dev-develop as ~2.3@dev",

I am just using clean RAD edition, cloned this night
When I open the homepage - I get

ServiceCircularReferenceException: Circular reference detected for service 
"knp_rad.domain_event.dispatcher.delayed", path: "knp_rad.domain_event.dispatcher.delayed -> 
doctrine.dbal.default_connection.event_manager".

this is another issue, #163

@docteurklein so we can not have the release at the moment since c9f7b0b(which is parent commit for #163 (comment)) does contain the same Knp\RadBundle\Controller\Controller::createAccessDeniedException->createAccessDeniedException()
:(

I just pushed a new tag: 2.5.0

BTW, we need to be more semver compliant, because currently: noidea

closing for now. thanks!