KnpLabs / Gaufrette

PHP library that provides a filesystem abstraction layer − will be a feast for your files!

Home Page:http://knplabs.github.io/Gaufrette

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Deprecated adapters removed in incorrect version

chrisaligent opened this issue · comments

Hi,
Just updated an application and found major breakages, tracked it down to this plugin.

The Adapters have been warning about deprecation since 0.4:

@trigger_error('The ' . __NAMESPACE__ . '\Cache adapter is deprecated since version 0.4 and will be removed in 1.0.', E_USER_DEPRECATED);

This is completely fine, but they didn't get removed in 1.0.0, they were removed in 0.10.0 (tagged just over a month ago). So their removal was completely unexpected and caused a BC break (it's also a SemVer violation).

Locking down our composer.json to the older version until all dependencies have caught up is a simple workaround, but it's worth noting in case others have the same problem. Our composer.lock file says we upgrade from 0.9.0 to 0.10.0.

tldr: 0.1.0 !== 1.0.0

Hey.

You are correct. They were removed earlier than the deprecation message said. However, it is not a SemVer violation. SemVer acts differently before 1.0.

Ah yes, that makes sense.
I've locked our application back at 0.9.0 and everything seems to be working well again 👍
I will notify the platform developers that they should lock down to 0.9.0 as well, as there are still parts of their codebase which try to use those removed adapters, and I don't think they've realised that the adapters have vanished in the latest release.

@chrisaligent please close am issue