Kludex / python-multipart

A streaming multipart parser for Python.

Home Page:https://kludex.github.io/python-multipart/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Name clash with `multipart` package.

tomchristie opened this issue · comments

I don't especially mind that both multipart and python-multipart exist on PyPI, but it's a bit awkward that they both also install as multipart.

I've already managed to bump my head on this, and couldn't understand why the signature for multipart.MultipartParser wasn't as expected having had both packages installed at some point.

Although I much prefer the plain multipart name I wonder if it's worth considering something like multipartparser?

Alternatively we don't worry about it for now, and consider something later if it's an issue. Not sure.

I would like to second this. It's quite hard to detect when it happens, it took 3 of us for a whole day (or more) to finally discover we had both packages installed. I was about to call a server exorcist 😂

Of course, it was a bug in our code to have both installed, but the fact that sometimes one is used and some times the other for the same multipart makes it especially difficult to debug.

Would you consider changing the import name as @tomchristie suggests? 🙏

I'm not fixing this.

My intention is to maintain this package till we merge the code to Starlette.