Giters

KhronosGroup / OpenXR-SDK-Source

Sources for OpenXR loader, basic API layers, and example code.

Home Page:https://khronos.org/openxr

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong calling convention for layers on 32-bit Windows

SEt-t opened this issue · comments

commented

Loader expects xrNegotiateLoaderApiLayerInterfaceto use __stdcall convention for Win32 target:

OpenXR-SDK-Source/src/loader/api_layer_interface.cpp

Line 280 in 15c3d8e

auto negotiate = reinterpret_cast<PFN_xrNegotiateLoaderApiLayerInterface>(

OpenXR-SDK-Source/src/common/loader_interfaces.h

Line 78 in 7450c54

typedef XrResult(XRAPI_PTR *PFN_xrNegotiateLoaderApiLayerInterface)(const XrNegotiateLoaderInfo *loaderInfo,

OpenXR-SDK-Source/include/openxr/openxr_platform_defines.h

Line 31 in 7450c54

#define XRAPI_CALL __stdcall

But layer's code specifies no calling convention:

OpenXR-SDK-Source/src/api_layers/core_validation.cpp

Line 845 in ff3325c

LAYER_EXPORT XrResult xrNegotiateLoaderApiLayerInterface(const XrNegotiateLoaderInfo *loaderInfo, const char * /*apiLayerName*/,

what results in use of default one (usually, __cdecl) and crash in loader due to convention mismatch.

commented

An issue (number 1929) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1929 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.

commented

This was fixed in 1.0.27!