KevinNovak / Friend-Time

Discord bot - Friend Time helps your server coordinate times and events by converting times mentioned in chat between time zones!

Home Page:https://novakevin.gitbook.io/friend-time

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Time detection / parsing (yearly salary)

tchaflich opened this issue · comments

One message that the bot reacted to:

image

I was wondering what it could have thought was a time in there (my best guess was "year"), but it responded with this:

image

had a base salary of $927,000 a year.

It detected the part of the salary after the comma, a space, and the letter "a" and interpreted that as midnight (I assume, since NL and US are six hours apart).

I would suggest that any commas that are part of a formatted numeric string (including currency signs, decimal points, commas, negative signs, and numeric characters) not be considered as a time.


It's also a side note, but 000 (a|p) both parse as valid times (noon and midnight). I don't know of any time format that represents time in quite this way. The mixture of three digits and meridian indicator doesn't seem to work for non-zero digits (for example, 111 a is not picked up by the bot as a valid time).