Giters

Kerogi / Fraction-Calculator

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Constructors from strings fails

Kerogi opened this issue · comments

commented

Failed next tests:

  • Fraction_Calculator.Test.FractionConversionTest.ConstructionSimpleStringTest
  • Fraction_Calculator.Test.FractionTest.ConstructFractionFromString
  • Fraction_Calculator.Test.FractionTest.DecimalStringParsingTest
commented

In some locales numbers is written using dot and in another using coma.

The current code expect the first case(dot).

Possible solution is to make two separate methods:

1. Expects string with number in neutral locale
2. Expects string with number and locale in which this number is written

Or take the thread locale found it format and then convert given string with number it in neutral locale.