Kashio / A5

C++ Custom memory allocators

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[question] is m_PrevSize variable used in FreeTreeAllocator

odygrd opened this issue · comments

Hello, thanks for sharing the library and the benchmarks it looks very useful.

In FreeTreeAllocator there is a variable m_PrevSize it looks like this variable is not used anywhere.
There is also m_PrevSize variable in the RBTree structure here https://github.com/Kashio/A5/blob/master/include/A5/RBTree.h#L19 it looks like there is a check for it in FreeTreeAllocator here https://github.com/Kashio/A5/blob/master/src/FreeTreeAllocator.cpp#L100 but it looks like it is not set anywhere to a non-zero value.

Is that variable being used at all ? Or could you please explain where is it used ?

Thanks

Sorry you can ignore this noticed that
*nextBlockAddress = sizeof(Header) + curr->m_Value; sets the m_PrevSize and the Header has to follow the same structure as the RBTree node