Doesn't build on non-GNU systems due to use of parallel/numeric

Question

Doesn't build on non-GNU systems due to use of parallel/numeric

yurivict opened this issue 2 years ago · comments

parallel/numeric is Linux-only.

Demian Hespe · Answer 1 · Fri Jul 01 2022 15:28:10 GMT+0800 (China Standard Time)

parallel/numeric seems to only be used in the maximum matching code (lib/mis/kernel/ParFastKer/fast_reductions/src/MaximumMatching.cpp). In parallel/* there are some stl algorithms implemented in parallel - in particular, here only partial_sum is used. If you just want to make this compile on non-GNU systems, you could just replace <parallel/numeric> with <numeric> and __gnu_parallel::partial_sum with std:partial_sum. But be aware that this will probably slow down kernelization a bit because it would then compute prefix sums sequentially.

yuri@FreeBSD · Answer 2 · Fri Jul 01 2022 16:57:29 GMT+0800 (China Standard Time)

This advise seems to work. Thanks!

Darren Strash · Answer 3 · Thu Jul 07 2022 04:37:37 GMT+0800 (China Standard Time)

Hi @yurivict, I've written and am testing an algorithm that will make parallel/numeric no longer needed. I would propose that we discuss making the FreeBSD port. We would like to make sure that the port is as efficient as our original implementation (i.e., to ensure the running times are consistent with our papers). Can I help with this endeavor? If so, is it possible to commit all of the necessary changes to the github repo, or is there much more that needs to be done for the port?

yuri@FreeBSD · Answer 4 · Thu Jul 07 2022 04:45:16 GMT+0800 (China Standard Time)

Hi @darrenstrash

Thanks for your offer.

The port already exists.
commit info
FreshPorts record

I couldn't find how to run the testsuit.

Yuri

Darren Strash · Answer 5 · Thu Jul 07 2022 05:35:01 GMT+0800 (China Standard Time)

Thanks @yurivict

Just to check: In the commit info, are those the only changes that you had to make from our git repo to your port?

Re testsuite: While some of the algorithms are deterministic, several of them are actually non-deterministic and therefore hard to test. The main performance metric we care about, time, is difficult to write automated tests for. I will try out your port and let you know if I see performance similar to our papers.

yuri@FreeBSD · Answer 6 · Thu Jul 07 2022 05:36:51 GMT+0800 (China Standard Time)

Just to check: In the commit info, are those the only changes that you had to make from our git repo to your port?

This commit contains all changes needed to add the port.

Re testsuite: While some of the algorithms are deterministic, several of them are actually non-deterministic and therefore hard to test. The main performance metric we care about, time, is difficult to write automated tests for. I will try out your port and let you know if I see performance similar to our papers.

Thanks.