Play 2.8 support

Question

Play 2.8 support

aljchristensen opened this issue 4 years ago · comments

Anthony Christensen commented 4 years ago

Similar to #16, I'm running into issues migrating from Play 2.7 to 2.8. I'm encountering the error below:

CreationException: Unable to create injector, see the following errors:

1) Error injecting constructor, java.lang.NoSuchMethodError: 'void play.api.i18n.DefaultMessagesApi.<init>(scala.collection.immutable.Map, play.api.i18n.Langs, java.lang.String, boolean, boolean, scala.Option, play.api.http.HttpConfiguration)'
  at play.ext.i18n.MultiFormatMessagesApi.<init>(MultiFormatMessagesModule.scala:16)
  at play.ext.i18n.MultiFormatMessagesApi.class(MultiFormatMessagesModule.scala:16)
  while locating play.ext.i18n.MultiFormatMessagesApi
  while locating play.api.i18n.MessagesApi
    for the 1st parameter of play.i18n.MessagesApi.<init>(MessagesApi.java:32)
  at play.ext.i18n.MultiFormatMessagesModule.bindings(MultiFormatMessagesModule.scala:53):
Binding(class play.i18n.MessagesApi to self) (via modules: com.google.inject.util.Modules$OverrideModule -> play.api.inject.guice.GuiceableModuleConversions$$anon$4)
  while locating play.i18n.MessagesApi
...

Do you plan to support Play 2.8? Thank you!

Karel Cemus · Answer 1 · Wed Sep 23 2020 14:26:41 GMT+0800 (China Standard Time)

I wasn't but I can. I didn't know that somebody actually uses this library. I will look at it probably today and see what I can do

Karel Cemus · Answer 2 · Wed Sep 23 2020 19:52:23 GMT+0800 (China Standard Time)

Released version 2.1.0, should be in maven repos in a couple of hours. Are you willing to test it and give me some feedback? I slightly revamped the provider of MessagesApi so I hope it works

Anthony Christensen · Answer 3 · Wed Sep 23 2020 22:12:54 GMT+0800 (China Standard Time)

As far as I can tell, everything seems to be working as expected with the new release. Thanks so much for taking a look at this so quickly.

Karel Cemus · Answer 4 · Wed Sep 23 2020 22:19:24 GMT+0800 (China Standard Time)

Happy to hear, thanks for the feedback

Krishna Gaurav · Answer 5 · Wed Jan 18 2023 04:26:19 GMT+0800 (China Standard Time)

Hi @KarelCemus i am using 2.8.16 and still seeing this issue
[info] java.lang.NoSuchMethodError: 'void play.api.i18n.DefaultMessagesApi.<init>(scala.collection.immutable.Map, play.api.i18n.Langs, java.lang.String, boolean, boolean, scala.Option, play.api.http.HttpConfiguration)'
could you please direct me to the version with the fix.

Karel Cemus · Answer 6 · Wed Jan 18 2023 05:09:03 GMT+0800 (China Standard Time)

Which version of play-i18n are you using? Btw it is more convenient if you can provide the full stacktrace or at least the significant part of it, since errors without any context cannot be debugged or reproduced

Krishna Gaurav · Answer 7 · Wed Jan 18 2023 05:25:58 GMT+0800 (China Standard Time)

Thanks for replying. I don't have a dependency defined for play-118n. Here is trace
[info] java.lang.NoSuchMethodError: 'void play.api.i18n.DefaultMessagesApi.<init>(scala.collection.immutable.Map, play.api.i18n.Langs, java.lang.String, boolean, boolean, scala.Option, play.api.http.HttpConfiguration)' [info] at com.xx.xxx.xxx.util.test.playHelpers$.defaultControllerComponents(playHelpers.scala:183) [info] at controllers.GraphQLControllerTest$TestEnv.createGqlController(GraphQLControllerTest.scala:415) [info] at controllers.GraphQLControllerTest$TestEnv.<init>(GraphQLControllerTest.scala:379)

Karel Cemus · Answer 8 · Wed Jan 18 2023 05:48:51 GMT+0800 (China Standard Time)

If you don't use have a dependency on play-i18n then you don't have an error related to this library :-) The name of this lib is a bit unfortunate but this is not the official play-i18n dependency, this is a custom implementation. Therefore it is not wired to your project

Your code at com.xx.xxx.xxx.util.test.playHelpers$.defaultControllerComponents(playHelpers.scala:183) is complied against a different/old version of play, I guess