Is this a bug in the GGX renderer?
Jarvisss opened this issue · comments
In the Cook-Torrance BRDF
f_specular = D * F * G / (4 * (n dot v) * (n dot l)),
In the co-located setting, you assume v==l,
so the equation should be
f_specular = D * F * G / (4 * (n dot v) ** 2)
, right?
but in your code implementation,
Line 69 in 8e9a7c1
it is
f_specular = D * F * G / (4 * (n dot v)
,not
f_specular = D * F * G / (4 * (n dot v) ** 2)
Could you have a look at this? @Kai-46