Kagami / gulp-ng-annotate

:pushpin: Add angularjs dependency injection annotations with ng-annotate

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Error in plugin 'gulp-ng-annotate' > Streaming not supported

filipedeschamps opened this issue · comments

Hi!

I'm trying to browserify my app and ng-annotateit, but I'm receiving and error message about stream not supported. Is the correct approach use something like gulp-streamify? https://github.com/nfroidure/gulp-streamify

My current task

gulp.task('build-scripts', function() {
  return browserify(configurations.paths.client + 'site/index.js')
  .bundle()
  .pipe(plumber())
  .pipe(source('site.js'))
  .pipe(ngAnnotate())
  .pipe(gulp.dest(configurations.paths.content.themes + 'default/scripts/'));
});

Error message

[11:55:47] Plumber found unhandled error:
 Error in plugin 'gulp-ng-annotate'
Streaming not supported

Hi.
Yes, gulp-ng-annotate doesn't support vinyl streams currently because I've used official gulp guide when wrote it and the common way to handle the stream was simply to throw an error (a lot of gulp plugins still doing this).
Though now it's recommended to support streams so I will keep this issue opened and going to implement it in near future (or maybe someone will help with a PR). As a temporary workaround gulp-streamify should fit your needs, yeap. Thanks for the feedback.

I've implemented basic and barely tested support for streams in 0.4.3. Could you test it please?

Tested and it's working perfectly! Thank you very much @Kagami you rock !!!