Setup Coveralls
GittiHab opened this issue · comments
I have tried setting up Coveralls using the Python coveralls plugin – but it seems to have some difficulties running in Docker. Maybe someone can look over it.
There is a branch coveralls which should already contain some configuration. The repository is already connected to Coveralls.io. Should you have trouble seeing the Repo/Organization there try to make your membership in the Organization public (More on how to solve this here – especially around the part where the issue was originally closed).
Could you please describe your problems further?
@GittiHab Please talk with us 😉 We would save time if we wouldn't test the exact same things repeatedly like using directly travis without Docker, this won't work because travis uses a Ubuntu version where graph-tool is broken.
@Baschdl Following the instructions on the Python Coveralls module it turns out that it expects to be run directly in Travis – that's why I just wanted to try that out but, as you pointed out, graph-tool doesn't like that. If you like, you can look into the error log on Travis before I removed the docker part.
Trying to talk to you is exactly what I have been trying to do by opening this issue. (I didn't expect you to work on this Fridays, anyways)
This Travis build is especially helpful. Of course, you can probably test it locally but I have been having trouble there, too.
There is probably some solution somehow but I am not sure if it's worth it.
"Friday is burger day" (@WGierke) so it would be a shame to not work today
@Baschdl work yes, but on this? Seems to be promising. But I have already invested enough time on this today, I actually planned on doing other things. Maybe you can take a look and make Travis happy again
I probably also have no time for this today
I also planned on having a nice Friday burger with some friends today but life isn't always a bowl of cherries.
I have added a documentation on Travis/Docker for the future https://github.com/KDD-OpenSource/32de-python/wiki/Continuous-Integration-and-Docker
Runs locally... but not on Travis.
It seems that the .coverage file contains the wrong paths (the ones from docker not travis). Maybe coverage combine works differently with python 3.6. This should be debugged.
The first idea for debugging is to print the file on travis with cat.
Sadly, this didn't tell us anything new. Link to Travis build
Travis goes into the 32de-python-folder by running cd KDD-OpenSource/32de-python when running git clone --depth=50 --branch=coveralls https://github.com/KDD-OpenSource/32de-python.git KDD-OpenSource/32de-python. So it can't find the python file in /32de-python/active_learning/__init__.py because this file is in active_learning/__init__.py.
The path prefix /32de-python/... comes from Docker as this is the absolute path to the file in the container. Whereas in Travis the absolute path to the file would be /OpenSource/32de-python/...
But it would be sufficient to use the relative path ... (in your example), so for example active_learning/__init__.py and everything would be fixed?
I am not the one specifying the path – it is the coverage module of python doing it. I indeed specified a relative path in .coveragerc that should be used when merging .coverage file (these are the generated one with the absolute path). This is also what it does locally which is why it works locally.
OK, I manually replaced it now... that "fixes" the issue.
GitHub doesn't seem to have noticed that the PR solved this.
Nice work :D