Giters

KC3Kai / KC3Kai

Kantai Collection Game Viewer and Tools

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Suggestion] Add language localization support for Strategy Room

Izayoi-Homura opened this issue · comments

commented

KC3改 has great language support in both information panel and settings page.
However, Strategy Room, which is an important part of KC3改 and has powerful tools, only supports English.
I think it is a pity and actually I tried to directly edit pages\strategy\strategy.html, and KC3改 just crashed.

If Strategy Room of KC3改 supports localization, I can help for the work of translation into both Traditional and Simplified Chinese.

commented

I had opened a pull request.

  1. terms_extended.json is still unable be included, so I just edit terms.json for test.
  2. strategy.html - almost finished
  3. profile.html - partially finished (to Statistics)
  4. supporting language - currently English, Simplified and Traditional Chinese
    2022/10/29 18:29

Snapshots
Traditional Chinese
Simplified Chinese
Also tested English and it worked well, but it had no differences with the origin version, so I did not take snapshot.

commented

Ive seen and appreciated ur passion, but obviously u r lacking skills yet.
Ive merged the extend support into both repos now, should be easier to do the translations for Strategy Room.
Before u have learned those knowhow abou git/github, editing kc3 codes, suggest u to practice via updating current defined but missing terms, or quests or quotes for sch or tch by single repo pull requests (short for PR), without touching main repo html/js to avoid mess or conflict.
To be honest, quests and quotes are out of date for long time either, and useful for players in those languages.

I don't have much time, but will define EN terms a little bit every day. When u have learned enough and been ready to, it's big welcome to contribute to main repo too.

I'll write some instructions on the steps of github fork & PR workflow later.

commented

Thank you for your reply and I appreciate your kindness and patience.
Quests and quotes (subtitles for voice) are also issues I want to suggest. I know they are out of date now, tcn quests was updated 4 months ago and scn quests 2 years ago.
Actually, kcanotify have scn and tcn quest files just 5 days ago.
https://github.com/antest1/kcanotify-gamedata/tree/master/files
antest1 mentioned "Translation data for ships, equipments and quest are mainly from kc3-translations." in README.md in main kcanotify repo, but they are more up-to-date now.
On the otherside, Chinese quotes(subtitles) are now mainly maintained by kcwiki. They suppy an API to get Chinese subtitle translation.
https://github.com/kcwikizh/kcwiki-api/wiki/Subtitle
If you agree with my suggestion, I could post an issue on Kcanotify and KcwikiAPI repos respectively, ask if we could use their translation.
The way to use, from only copying text to more automatic methods, could be discussed later.

commented

not necessary to post issue, i guess. kc3's scn quotes were from zhwiki by semi-auto copying. just need someone to continue it, should be fine.
feel free to do it if u could, do not need agreement from me. i'm just one of activated contributors, could help to check if the modifications break sth or not.