Create buffer from user defined class

Question

Create buffer from user defined class

diegomazala opened this issue 6 years ago · comments

I couldn't use your circular_buffer with any of my defined types. For instance, none of the classes defined here https://en.cppreference.com/w/cpp/language/rule_of_three
I am using msvc 2017 and it throws an error nad a warning:

warning C4624: 'jm::circular_buffer<my_type,3>': destructor was implicitly defined as deleted
'jm::circular_buffer<my_type,3>::~circular_buffer(void)': attempting to reference a deleted function

Thanks

Justas Masiulis · Answer 1 · Wed Jul 11 2018 04:35:49 GMT+0800 (China Standard Time)

Thanks for reporting this.
The problem was that the storage class which is an union had either defaulted or no destructor defined. When the type had a non trivial destructor this became a problem.

TLDR: should be fixed now (for c++11 and up at least).

Diego Mazala · Answer 2 · Wed Jul 11 2018 04:51:00 GMT+0800 (China Standard Time)

Yes! Well done! Thank you Em ter, 10 de jul de 2018 às 17:35, Justas Masiulis < notifications@github.com> escreveu:

…

should be fixed now — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFpfhoRA4QoYTe4xchL1_yM1CBA08TqJks5uFRAmgaJpZM4VJ4hp> .