JureSotosek / ink-divider

๐Ÿ‘จ๐Ÿผโ€๐ŸŽจ Divider component for Ink

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Divider doesn't match screenshot in readme

ezzak opened this issue ยท comments

commented

I'm not sure the divider is really a divider anymore...

image

Huh? I just tried the examples and this is how they show for me:
Screenshot 2019-07-20 at 13 43 07

Can you post the props / the code you used to achieve this?

commented
<React.Fragment>
  <Divider title="Test" width={20} />
  {...otherComponents}
</React.Fragment>

^ Above rendered via render(<MyComponent />, process.stderr)

VSCode terminal:

image

iTerm2:
image

Rendering this:

import React from 'react';
import { render } from 'ink';
import Divider from '..';

const Basic = () => (
  <React.Fragment>
    <Divider title="Test" width={20} />
  </React.Fragment>
);

render(<Basic />);

Gives me this:

Screenshot 2019-07-21 at 21 27 11

Can you link me a project or something where this happens? That would be really helpful โœŒ๐Ÿผ

Hmmm, the problem seems to be when switching from ink@2.0.0 to ink@2.1.0. Not sure why, but in that version, Color element switched from being an inline element to being a block element. Not sure if this is the intended behavior or a bug.

Will push a quick update that will fix this issue.

Bug fixed with ink-divider@2.0.1 ๐Ÿ‘๐Ÿผ