JulianNorton / weather-10kb-wxkb

Weather forecast that's high performance and accessible

Home Page:https://wxkb.juliannorton.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add automated accessibility testing

Tardog opened this issue · comments

Browser accessibility check should run automatically as part of the build process, e.g. during integration testing.

Isn’t tenon.io a paid service? They provide a 30 day free trial and "special offers" for open source projects. No idea if these special offers are free, though.

Karl from Tenon has been kind enough to provide a complimentary API key, which we shouldn't share publicly. I have added it as an environmental variable on CircleCI so pull-requests can use it without exposing the key itself. What do you think @Tardog ?

screen shot 2017-06-15 at 2 40 01 pm

Tenon it is, then!

Of course, contributors won’t be able to run the Tenon tests locally (provided they don’t have an API key of their own, of course). In my opinion, this is not a huge issue. We still gain a lot from automatic testing, and anyone submitting a PR will get timely feedback if their changes affected the build.

The test runner could check for the presence of a TENON_API_KEY in the environment and simply skip the accessibility tests if none is found.

I’ve got time to work on this (finally!) and plan to start later today. If anyone else has already begun work on this issue, please let me know.

@Tardog I just want to confirm if there's anything else to be done.

Does the PR resolve this issue? 1e46363

✓ should pass tenon.io accessibility tests (1634ms)

Just found it worked in the last PR 🏁