Giters

JulianNorton / weather-10kb-wxkb

Weather forecast that's high performance and accessible

Home Page:https://wxkb.juliannorton.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Upgrade to Node 7.x

Tardog opened this issue · comments

commented

According to https://devcenter.heroku.com/articles/nodejs-support Heroku supports the latest stable Node.js version. I suggest updating the app and incorporate more modern language features from ES6 and ES7 to clean up the code.

commented

I've since switched away from Heroku's free tier and am hosting wxkb on a Digital Ocean droplet.

  • Linux xenial-512mb-nyc3 4.4.0-47-generic #68-Ubuntu SMP

No reservations from upgrading to es7, though it may introduce some bugs.

commented

Great! I will start working on this. Do you mind if I add unit tests and possibly integration testing to the app before upgrading? With a good testing base, detecting if stuff was broken during the refactoring and fixing it is going to be much easier.

commented

I would love if testing were added, that's a great addition. Go for it!

commented

I think writing tests should be a separate issue, and it should be solved before performing the Node upgrade and refactoring to ES7.

commented

#135 new unit test issue!

commented

@Tardog any progress on refactoring? Hesitant to touch the backend while this work is being done.

commented

@loctn I’m currently moving some code around while working on #135, breaking up files with multiple classes into modules and separating routes from business logic. Depending on what you are planning to change, it might be better to wait until the test suite is finished.

commented

@Tardog got it, I'll await your efforts before I touch the Node stuff 😄.

commented

I left some remarks in #139, and this should be closed pending review.