JuliaNLSolvers / NLsolve.jl

Julia solvers for systems of nonlinear equations and mixed complementarity problems

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Can call to mul! in newton.ls saved ?

amartinhuertas opened this issue · comments

Dear NLsolve.jl developers,

I think that the following call to mul!:

https://github.com/JuliaNLSolvers/NLsolve.jl/blob/master/src/solvers/newton.jl#L94

can be saved if linesearch isa Static evaluates to true. Note that cache.g is only consumed in this line:

https://github.com/JuliaNLSolvers/NLsolve.jl/blob/master/src/solvers/newton.jl#L119

am I right? Is there anything I am missing?

Thanks! @amartinhuertas

Sorry, I didn't see this earlier, let me have a look.

You mean like this right? #249

You mean like this right? #249

Yes, indeed! Thanks!

Sorry I didn't tag this change earlier. Had a thesis to finishing writing and hand in 😬 It's merged. I'll tag soon.