Giters

JuliaNLSolvers / NLsolve.jl

Julia solvers for systems of nonlinear equations and mixed complementarity problems

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

DiffEqDiffTools -> FiniteDiff

ikosmidis opened this issue · comments

commented

Hi NLsolve

DiffEqDiffTools has been renamed to FiniteDiff (see here)

As a result, I am getting "Method definition in module DiffEqDiffTools at XXX overwritten in module FiniteDiff at YYY" warnings, when I have
using NLsolve, FiniteDiff
in modules.

Any workarounds? Would depending on FiniteDiff (rather than DiffEqDiffTools), break anything?

Thanks
I

commented

It's all the same, so a quick PR for the new name would fix this. It sounds like one dependency updated and another didn't

commented

Just a bit more info from a quick look at the codebase

NLsolve has

[compat]
DiffEqDiffTools = "0.9, 0.10, 0.11, 0.12, 0.13, 0.14, 1"

But FiniteDiff is v2.0.0.

Also, DiffEqDiffTools seemed to have changed a few versions between 1.0.0 and when it got renamed to FiniteDiff.

NLsolversBase also depends on DiffEqDiffTools.

If someone more familiar with the codebase of these two packages did the fix, that'd be great!

Thx

commented

I see my NLSolversBase registration didn't go through last time, so I'll try again. We don't even use DiffEqDiffTools here anymore, so it should be very easy to fix.