JuliaNLSolvers / NLsolve.jl

Julia solvers for systems of nonlinear equations and mixed complementarity problems

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rename xtol, ftol to x_tol, f_tol?

amrods opened this issue · comments

Can I propose to rename options xtol, ftol to x_tol, f_tol to be consistent with Optim?

Yes! 👍

Happy to review a PR... if not, I'll get around to it at some point. I'm actually thinking about adding both x_reltol and x_abstol in Optim soon (and for f and g...), so maybe that's something to keep in mind ?

Ok, I will try to do it this weekend. Should be easy.