Use Static.jl to implement elements of Ones and Zeros?

[Oliver Schulz]

Currently, we have

Ones(5)[1] isa Float64

Using Static.jl, the elements of Ones could be static(1) or static(1.0), which would propagate the fact that the number is static deeper into calculations and could enable better compiler optimizations.

Static.jl is a comparatively lightweight dependency on top of FillArrays, load-time impact would probably be minor:

julia> @time using FillArrays
  0.398913 seconds (764.83 k allocations: 46.937 MiB, 72.11% compilation time)

julia> @time using Static
  0.062017 seconds (93.65 k allocations: 5.420 MiB)

[Sheehan Olver]

Can't you just use Fill(static(1),n) for this?

[Oliver Schulz]

Can't you just use Fill(static(1),n) for this?

I typically will. But Fill often get's lost e.g. by vcat (which I'll have to use a lot):

julia> vcat(Fill(static(1), 5), Fill(static(1), 5))
10-element Vector{StaticInt{1}}:

Speaking of which, explicit support for Static.jl would allow us to specialize things like vcat to return a Fill.

[Sheehan Olver]

I just think Ones{T} is a very different thing than what you want.

[Sheehan Olver]

Note this issue is basically the same as #104 so I'm closing this

[Oliver Schulz]

I just think Ones{T} is a very different thing than what you want.

You were right, I want Ones{StaticInt} and Ones{StaticFloat64}, not Ones{Int} and Ones{Float64} - sorry for the misunderstanding.