Conflict with Ultimate Member - "Form Changed" popup

Question

Conflict with Ultimate Member - "Form Changed" popup

neilgilmour opened this issue 6 years ago · comments

Expected Behavior

Navigating Ultimate Member pages in WP admin is a smooth and pleasant journey. Or at least as smooth and pleasant as it can be for Ultimate Member.

Actual Behavior

Navigating Ultimate Member pages in WP admin is not a smooth and pleasant journey. Every page change triggers a "Leave this page? content not saved" error.

Steps to Reproduce the Problem

Install VAA
Install Ultimate Member
navigate round some UM pages
throw computer out of window in frustration

Specifications

Plugin Version: 1.8
WordPress Version: 4.9.6
Other plugins installed: Ultimate Member 2.0.17
Theme: TwentySeventeen
Browser: Chrome

Jory Hogeveen · Answer 1 · Thu Jun 28 2018 02:09:35 GMT+0800 (China Standard Time)

@neilgilmour
Quick question, are you in a view when this error shows?
And are you using the free version?

Neil Gilmour · Answer 2 · Thu Jun 28 2018 02:57:09 GMT+0800 (China Standard Time)

No, default view. Free version of UM

…

On Wed, 27 Jun 2018 at 19:09, Jory Hogeveen ***@***.***> wrote: @neilgilmour <https://github.com/neilgilmour> Quick question, are you in a view when this error shows? And are you using the free version? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#93 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADSFVi00SAr-y1kqCyhUQ_6xhM8hC-NDks5uA8pfgaJpZM4U5zbA> .

Jory Hogeveen · Answer 3 · Thu Jun 28 2018 03:05:32 GMT+0800 (China Standard Time)

Are you sure the issue is with VAA?
Just installed Ultimate Member free on my dev site and can't find any noticeable changes in load time.

Jory Hogeveen · Answer 4 · Thu Jun 28 2018 03:20:02 GMT+0800 (China Standard Time)

Ah, hold on, I get what you mean! It's not about the load time but about the form-notice you get.
Funny thing, I noticed this with WooCommerce etc. too but it didn't came to mind that it could be VAA.
Will look into this!

Jory Hogeveen · Answer 5 · Thu Jun 28 2018 03:28:04 GMT+0800 (China Standard Time)

@neilgilmour
See commit 7724e22.
The problem was that JS was triggering a change on load to start some conditional handing but that also triggers the browser into believing that something in a form object was actually changed (which is not the case).