WebSocket subscription does not return `id` field

Question

WebSocket subscription does not return `id` field

cenkalti opened this issue 4 years ago · comments

Cenk Altı commented 4 years ago

https://docs.nano.org/integration-guides/websockets/#acknowledgement

If requests includes an id, it must be returned in acknowledgement message.

Joohansson (Json) · Answer 1 · Fri Sep 18 2020 14:19:12 GMT+0800 (China Standard Time)

Ok, will fix

Cenk Altı · Answer 2 · Tue Oct 06 2020 17:18:43 GMT+0800 (China Standard Time)

@Joohansson I can work on this and #16 if you want. Can I send you a PR?

Joohansson (Json) · Answer 3 · Tue Oct 06 2020 21:06:24 GMT+0800 (China Standard Time)

@Joohansson I can work on this and #16 if you want. Can I send you a PR?

@cenkalti Sure that would be great! I've been a bit busy lately. After the PR I just need to make sure it will work with Nault.cc as it's using this lib as the backend. Or if you want to check that yourself as part of it. You can specify your custom backend in the wallet. But that's just an extra check if you think it's fun.

Edit: Correction, Nault uses NanoRPCProxy when using nault.cc as backend (or when the random server chooses it)

Joohansson (Json) · Answer 4 · Thu Nov 05 2020 13:46:04 GMT+0800 (China Standard Time)

@cenkalti Did you start doing any work on this? Because I don't want to start if you already have something close to a PR? If not, just let me know and I will start looking into this myself.

Cenk Altı · Answer 5 · Thu Nov 05 2020 21:04:01 GMT+0800 (China Standard Time)

@Joohansson I am sorry I couldn't start working on this yet. I am moving my house and I am very busy at the moment. I don't think that I can work on this near future. Please go on if you have time.