JonnyBGod / ngx-scrollspy

Angular ScrollSpy Service

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ScrollSpyElementDirective doesn't work

NatsuOnFire opened this issue · comments

Hi,
I tried to add ng2-scrollspy to angular2 webpack starter 2.1.1 project but when I want to use ScrollSpyElementDirective I am getting no console.log.

Sorry, It works fine.
I thought that the scroll on an element would act when we get to that element in the page.
I did not think it was on the scroll of that same element and it's not the same as Waypoints

That is a good use case. It should be possible to implement with a directive. Will probably add it when I get the time.

I've implemented a rudimentary Waypoints script using ng2-scrollspy, for anyone who need it: https://gist.github.com/Kamshak/63661e7ea251c92364a2ed1238f04264

@Kamshak Cool thank you for mentioning. Would you like to turn it into a plugin to be included in this repo?

The code works in a basic setup but i'm not sure if it will work for nested scroll panels. There are also some features that one could add (a Z offset for detection) and scroll directions.

At the moment i can't adapt it for more cases however feel free to add it as plugin maybe it will be useful for someone. Could act as a starting point