[Bug] Losing cards from stack when device orientation is rotated
Proudspark opened this issue · comments
New Issue Checklist
- I updated VerticalCardSwiper to the latest version.
- I read the Contribution Guidelines.
- I read the documentation.
- I searched for existing GitHub issues.
Bug Description
Changing device orientation to landscape removes some cards from view
To Reproduce
Steps to reproduce the behavior:
- Create more than one card for testing (eg 8), using normal methods.
- Use numbers in sequential labelling visible on cards
- Allow view to rotate to landscape orientation
- Notice that only even numbered labels are visible
Expected behavior
Not expecting views to resize to landscape view (another issue, another day), but expecting to see all available cards in stack. Looking at card No 1 reverts to card No 2 when rotated to landscape. Looking at card No 3 reverts to No 6 when rotated.
Environment
- iOS Version: [13.7]
- Device(s): [iPhone X]
- Xcode Version: [11.7]
Notice that only even numbered labels are visible
I'm not sure I fully understand you here, do you mean some cards are actually missing or are they just scrolled away?
From my testing on the example project I can indeed see that when you rotate to landscape the focussedItem is "lost" and the offset is incorrect, is that what you mean?
Here is a video which may help to explain issue a little better 8•)
I'm not sure if that's a bug with the library, when I modify the Example project to show the index instead of the age in the demo cards this does not happen as far as I can tell.
It does however end up on a different index which might be the underlying issue, are you doing anything special with your indexes?
Here's a modified example project which doesn't do this (I just replaced the age with index and added landscape support):
VerticalCardSwiper.zip
Any update on this?
Here is a video which may help to explain issue a little better 8•)
How do you maintain your cards centered even rotated to landscape? My stack moves into a corner.
@JoniVR - hi there, I saw it working as expected in the modified example you gave. So still need to figure this one out...
@alamodey - this centering is done with setting constraints on storyboard 👍
Do you mind elaborating what setting you are applying, as my view already takes up the whole screen but it's just the cards that are off-center.
