JonathanShor / DoubletDetection

Doublet detection in single-cell RNA-seq data.

Home Page:https://doubletdetection.readthedocs.io/en/stable/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Conform to sklearn estimator API

JonathanShor opened this issue · comments

Changes required include, at least:

  1. .fit(X) returns the class instance, not the labels, to allow chained calls (clf.fit(X).predict(X)).
  2. Add .predict(X).
  3. Add .predict_proba(X).
    3a. Not sure that we need .predict_log_proba(X)

What will .predict_proba(X) return? The voting average or all p-values?

I also see a number of issues with the docstring, but I'm assuming we will update those with the 2.0 release.