doublet_rate is confusing to everyone I've explained this to
adamgayoso opened this issue · comments
Adam Gayoso commented
maybe we change the name of the parameter
Ryan Brand commented
Maybe it would be more intuitive if we called it percent_synthetic or percent_doublets and made it equivalent to the percentage of the new dataset made up of doublets/synthetics
Jonathan Shor commented
My suggestion: boost_rate
Adam Gayoso commented
I like boost_rate.
…On Thu, May 4, 2017 at 11:36 AM Jonathan Shor ***@***.***> wrote:
My suggestion: boost_rate
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKWzsGyaVp5xnzsjxmfdgQ0JlJhQvWFZks5r2fCBgaJpZM4NQH_w>
.
Adam Gayoso commented
Just noting that this issue will be resolved in the class restructure
Jonathan Shor commented
Yes. The relevant commit is d657213.