When source image size exactly matches the requested width it is excluded from the generated output

Question

When source image size exactly matches the requested width it is excluded from the generated output

PickleyD opened this issue a year ago · comments

import myImage from 'image.png?w=980;490'

If image.png is 980px wide exactly only the 490px size is included in the generated output, meaning that in my app at screen sizes >980px the small 490px image is displayed. Is this a bug?

If image.png is larger than 980px then the 980px size is generated as I expected.

To work around this issue temporarily I can add the 979px size which is still generated where image.png is 980px exactly:

import myImage from 'image.png?w=980;979;490'

Jiabin Peng · Answer 1 · Thu May 25 2023 17:57:21 GMT+0800 (China Standard Time)

maybe try

import myImage from 'image.png?w=980;490&allowUpscale=true'

bf391fd

@benmccann

Pavlo Tkachov · Answer 2 · Tue Jun 06 2023 06:35:47 GMT+0800 (China Standard Time)

I hit the same issue with vite-imagetools 5.0.4.
I also have the 4.0.12 in another project and I don't recall this issue popping up before, which makes me think it's a new one.

allowUpscale works (although it's not in the directives documentation), but it's a temporary workaround and this is definitely a bug.

Matt Durkin · Answer 3 · Tue Jun 06 2023 18:03:19 GMT+0800 (China Standard Time)

Thank you @dgeibi for the workaround. I agree with you @pavlo-tk that this should be considered a bug given the context you have both provided.

Ben McCann · Answer 4 · Wed Oct 18 2023 02:09:05 GMT+0800 (China Standard Time)

I believe this issue was address. Can you please test again?

Ben McCann · Answer 5 · Thu Oct 19 2023 00:01:59 GMT+0800 (China Standard Time)

This was fixed July 6 in 5.0.5. I'm going to close this as fixed since all the comments are from before that date