JonMagon / KDiskMark

A simple open-source disk benchmark tool for Linux distros

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Flatpak request

skobkin opened this issue · comments

I saw that Flatpak was also requested in #34, but it wasn't implemented, so I'm leaving this feature request here.
Flatpak is available on some platforms where store app does not support backends like Snap or AppImage.
Good example is SteamOS 3 on Steam Deck where only Flatpak is available.

AppImage should work on SteamOS

It works, but it's not installable via Discover and couldn't be auto-updated there.

Well that makes sense. Although I was somewhat hopeful that the person in that issue would package. It will take me some time to get to grips with flatpack, as I'm not really a snap or flatpack amateur.

It seems to be working.

app-id: dev.jonmagon.kdiskmark
runtime: org.kde.Platform
runtime-version: '5.15-21.08'
sdk: org.kde.Sdk
command: kdiskmark
finish-args:
  - --socket=x11
  - --socket=wayland
  - --filesystem=host
  - --device=dri
modules:
  - name: kdiskmark
    buildsystem: cmake-ninja
    config-opts:
      - -DCMAKE_BUILD_TYPE=Release
      - -DROOT_EDITION=OFF
    sources:
      - type: git
        url: https://github.com/JonMagon/KDiskMark.git
        commit: b411c4ae0d4a4ab23531ae1fecddcf76a493a515
        x-checker-data:
          type: git
    modules:
      - name: fio
        buildsystem: simple
        build-commands: 
          - ./configure --prefix=$FLATPAK_DEST
          - make -j $FLATPAK_BUILDER_N_JOBS
          - make install
        sources:
          - type: git
            url: https://github.com/axboe/fio.git
            tag: fio-3.32
            commit: db7fc8d864dc4fb607a0379333a0db60431bd649
            x-checker-data:
              type: git
        modules:
          - name: libaio
            buildsystem: simple
            build-commands: 
              - make prefix=$FLATPAK_DEST install
            sources:
              - type: git
                url: https://pagure.io/libaio.git
                tag: libaio-0.3.113
                commit: 1b18bfafc6a2f7b9fa2c6be77a95afed8b7be448
                x-checker-data:
                type: git

Nice!

Will it be available on Flathub when you're sure that it's working totally fine?

Yes, need to read application requirements, hope --filesystem=host is allowed to use.

Honestly, I don't really understand what they want. If anyone understands this, you are welcome to do so.

It looks like they want you to either change the app-id to something github-related or register a domain for your app.

https://docs.flatpak.org/en/latest/conventions.html#application-ids

io.github.Foo This is problematic because while foo.github.io may be unique to your project, it does not include a project-specific identifier. This may cause issues if another project creates io.github.Foo-Bar which should be its own namespace but areas of flatpak may treat them similar. A better ID would be io.github.foo.Foo even if it is redundant.

It looks like they want you to either change the app-id to something github-related or register a domain for your app.

https://docs.flatpak.org/en/latest/conventions.html#application-ids

io.github.Foo This is problematic because while foo.github.io may be unique to your project, it does not include a project-specific identifier. This may cause issues if another project creates io.github.Foo-Bar which should be its own namespace but areas of flatpak may treat them similar. A better ID would be io.github.foo.Foo even if it is redundant.

Thank you, that makes more sense. It's curious the documentation is scattered all over the place.

You can try to check it: flatpak install flathub io.github.jonmagon.kdiskmark works for me fine.

Yes, I've tried on the Steam Deck and also on my desktop PC (Gentoo). Both worked fine. At least at a first glance.

Thank you!