The Great Refactoring: 469 Linter Warnings

Question

The Great Refactoring: 469 Linter Warnings

JohnathonNow opened this issue 4 years ago · comments

Sonar-lint reports almost 500 warnings, which is... bad. Any PRs that cut that down at all are greatly appreciated, so long as you don't open like, 40 to fix one each.

Raul Soledispa · Answer 1 · Thu Oct 01 2020 06:53:02 GMT+0800 (China Standard Time)

Hello, I would like to help you, can I assign myself?

John Westhoff · Answer 2 · Thu Oct 01 2020 12:15:39 GMT+0800 (China Standard Time)

Thanks very much!

Raul Soledispa · Answer 3 · Thu Oct 01 2020 14:22:55 GMT+0800 (China Standard Time)

Can you to share the report generate by Sonar Lint.
According to the analysis carried out on my machine there are 2446 issues

John Westhoff · Answer 4 · Fri Oct 02 2020 00:06:31 GMT+0800 (China Standard Time)

Sorry, I've only been using the sonar-lint extension built into VS Code and am not sure how to copy out its report. But it appears the 469 issues were only within the files I had open. Oof.

Justin K. · Answer 5 · Mon Oct 26 2020 04:33:20 GMT+0800 (China Standard Time)

I'm game to work on the linter issues, I'll start with sonar-lint's java:S1604 "Anonymous inner classes containing only one method should become lambdas", there's at least 22 in src/ui/ClothingChooser1.java (and I'll dig for others in the source tree)

Justin K. · Answer 6 · Tue Oct 27 2020 09:49:59 GMT+0800 (China Standard Time)

I definitely have not tackled all the issues, but pull request number 40 should help make some progress. I may still try to knock out some more, time permitting. (trying not to get this automatically linked to the request so that it doesn't chance automatically closing this issue, because it's only a partial fix)