Reorganize code
JohnathonNow opened this issue · comments
This codebase looks almost entirely unmaintainable, steps should be taken to improve that. There are many methods that contain far too much code, files with far too many classes, non-descriptive identifiers abound, lots of spaghetti, over 160 warnings from the linter, and more.
Is there a scope defined for this? Could you also point out which modules/areas of the code need refactoring on priority?
Scope-wise pretty much the entire project needs varying levels of un-fubaring.
Of highest priority would be Client.java, as it is an absolute mess.
Specifically, this networking code probably deserves its own class, and controls such as this and these should be centralized somewhere that makes sense. There's also the whole things with issues #11 and #1.
Thanks for the additional info, would it make sense to have separate issues for identified areas for refactoring. So the refactoring can happen incrementally (from multiple people) rather than the entire codebase at once?
I suppose that is a good point. I will create the other issues.