JohnMcLear / ep_print_preview_pdf

Etherpad, Preview PDF before printing..

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

PDF doesn't render

cmbirk opened this issue · comments

I thought I had already opened an issue for this, so if I opened one elsewhere I apologize.

I'm getting this error when trying to preview the pdf:

PDF.js v? (build: ?)
Message: Missing PDF "http://editor.mymadison.io:9001/static/plugins/ep_print_preview_pdf/static/compiled_pdfjs/web/undefined".

and the renderer is blank.

Ah, I did reference this somewhere else: JohnMcLear/ep_context#43

I'm still getting this error locally, and I think it's because the line

var pdfURL = $("#exportpdfa").attr("href");

when logged is undefined. I'm not sure where this attribute gets set.

Ah, this is getting set in core if Abiword exists. I don't have Abiword locally and haven't set the soffice setting. Giving that a try

Even after setting that attribute it's not showing as a replacement for Abiword. The export dropdown is still showing Abiword as uninstalled.

It looks like this may be caused in core in src/static/js/pad_impexp.js. It checks for clientVars.abiwordAvailable around line 213, and if not available it calls $('exportpdfa').remove(). It doesn't check that soffice is available, however.

I opened an issue for this in core here: ether/etherpad-lite#2858

@JohnMcLear this pull request to core fixes this for me: ether/etherpad-lite#2859

Pull request merged, closing this :)