JohnChangUK / Pneumonia-Kaggle

Model to predict pneumonia from chest X-ray scans

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Test validation process seems invalid (test_set is using train directory instead of test directory)

JordanMicahBennett opened this issue · comments

Good work on the project.

However, the "test_set " variable in line [21] from your pneumonia notebook, seems to be incorrectly defined.

It looks like the "test_dataGen.flow_from_directory" function's first parameter should be set to 'xray_dataset/test', instead of 'xray_dataset/train'.

The test set looks like it was accidentally set by original author as the training set, and in the end this would not reflect actual accuracy of model.

Snippet for quick view on issue:

image

Thanks for pointing this out Jordan, you're correct that it should be using the test data =)!

Thanks for pointing this out Jordan, you're correct that it should be using the test data =)!

Of course :)