The initial observation should include the address
jaromiru opened this issue · comments
The initial observation should include the address. If we assume that the attacker can only attack hosts with a known address, the current situation does not allow any action.
NetworkAttackSimulator/nasim/envs/state.py
Lines 117 to 118 in 4f78571
The code should include address=True.
Hey jaromiru, thanks for the pull request. I think you may a good point. I'm a bit busy at the moment but plan to have a deeper look into this when I have some spare time within the next fortnight.
Your right. Technically within Nasim, whether the address is known or not does not affect whether a given action will succeed or fail, since action success firstly depends on reachability and discovery. However, I can see that depending on your assumptions and how you are using the environment, observing the initial address is essential. Furthermore, I can't see any reason that it shouldn't be included in the initial observation.
I'll incorporate the proposed fix. Thanks again for the contribution.
Resolved by pull request fix #20