Giters

JialongJiang / DSPIN

Code and example of the D-SPIN framework

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

samp_mean.m rec_sample matrix, should it be reset at end of batch?

DiDeoxy opened this issue · comments

commented

Hello,

I was wondering if there should be a line between 62 and 63 in DSPIN/DSPIN_matlab/samp_mean.m that resets rec_sample to all ones?

Otherwise, rec_mean will have the previous means added to it again for each subsequent batch.

I don't know what the algorithm is trying to do exactly, but this seems incorrect on the face of it.

Cheers,

Max H.

commented

nvm, it makes no difference since rec_sample values are overwritten on each loop, not added to. Apologies.