Jeff-Lewis / cls-hooked

cls-hooked : CLS using AsynWrap or async_hooks instead of async-listener for node 4.7+

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Not working in node v10.0.0

josuerios opened this issue · comments

Test fails in node v10.0.0

Repro steps

  1. Install nodejs v10.0.0
  2. Run tests

context is being missed so tests breaks.

can it be related to nodejs/node@1cc6b993b9 ?

It looks like v10 needs a little review with regards to async_hooks. See Different async_hooks behavior in Node 10 #20274

Ah, after I ran into that Node 10 issue I had intended to see whether that also affected this library's functionality but I guess now I don't have to :(

i can confirm that cls-hooked is working in node 10.4
nodejs/node#20274 (comment)

Todo: Add warning or update npm node version requirements