Make difference between taps and holds

Question

Make difference between taps and holds

geritol opened this issue 9 years ago · comments

Tap event fires after release hold (holded for more than 2-5 secs). Is there a way to prevent onTap firing after releasing holds? So adding some time span that determines what should be considered tap vs hold (time between touch start and end).

Thanks a lot!

Hilke Heremans · Answer 1 · Sat Sep 05 2015 14:56:44 GMT+0800 (China Standard Time)

@geritol I forked & made some experimental changes to avoid sending an onTap after an onPress is triggered. I'll be testing it with some users next week. (Not ready to PR it yet since I'll likely have made mistakes after a crazy and exhausting coding week.

@JedWatson Any specific guidelines for a PR?

Hilke Heremans · Answer 2 · Fri Sep 25 2015 18:05:56 GMT+0800 (China Standard Time)

My changes seem to work fine, currently using it in production.

@JedWatson Still hungry for PR guidelines. Thanks. :-)

Daniel Cousens · Answer 3 · Wed Apr 04 2018 07:24:03 GMT+0800 (China Standard Time)

@hilkeheremans PR's accepted, I don't think there is any specific guidelines.
Tests are appreciated.