Giters

JanusGraph / janusgraph

JanusGraph: an open-source, distributed graph database

Home Page:https://janusgraph.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Documentation versions menu doesn't recognize latest version as latest

porunov opened this issue · comments

commented

As seen from the documentation https://docs.janusgraph.org/ versions menu doesn't respect latest version for some reason.

Screenshot from 2023-10-25 17-03-00

It could potentially be related to this file: https://github.com/JanusGraph/janusgraph/blob/master/docs/theme/structor-menu.js.gotmpl
Which produces the following output: https://github.com/JanusGraph/docs.janusgraph.org/blob/606b5611bfc55a3bc12a78f8aa11b2a2d7dccc00/v1.0/theme/js/structor-menu.js

const versions = [
  {path: "master", text: "Upcoming version", selected: false },
  {path: "v1.0", text: "v1.0 RC", selected: true },
  {path: "", text: "v0.6 Latest", selected: false },
  {path: "v0.5", text: "v0.5", selected: false },
  {path: "v0.4", text: "v0.4", selected: false },
  {path: "v0.3", text: "v0.3", selected: false },
  {path: "v0.2", text: "v0.2", selected: false },
];

However, it seems that the output should be the following:

const versions = [
  {path: "master", text: "Upcoming version", selected: false },
  {path: "", text: "v1.0", selected: true },
  {path: "v0.6", text: "v0.6", selected: false },
  {path: "v0.5", text: "v0.5", selected: false },
  {path: "v0.4", text: "v0.4", selected: false },
  {path: "v0.3", text: "v0.3", selected: false },
  {path: "v0.2", text: "v0.2", selected: false },
];
commented

Fixed it temporary by hardcoding versions in the menu. See this PR: #4079
We should revert this commit as soon as we fix this issue.

commented

at this point 1.0.0 wasn't marked as latest release yet.