bug in AABBTree.cpp
jksr opened this issue · comments
the implementation of insertLeaf has bug:
in line 132
AABBNode& leafNode = _nodes[leafNodeIndex];
but in line 192
unsigned newParentIndex = allocateNode();
if AABBNode pool gets resized in ln192, the reference in ln132 will cause problem.
It's better to change all this kind of "AABBnode&"s to "_nodes[index]" to avoid this kind of pitfall.
Anyway, thank you very much for the AABBTree code
Thanks for that - I'll investigate and take a look. Until writing this I'd really not done much C++ for years - think this project is the most I've written by far in over 10 years, and my goodness C++ has changed too!
If you notice anything else please do let me know (I'm not writing C++ regularly but always keen to keep these things up and learn).